[PATCH] D73484: [llvm-readobj] - Improve error message reported by DynRegionInfo.
    George Rimar via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Jan 30 01:30:32 PST 2020
    
    
  
grimar marked 2 inline comments as done.
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:139
+  /// Error prefix. Used for error reporting to provide more information.
+  std::string InfoContext;
+  /// Region size name. Used for error reporting.
----------------
jhenderson wrote:
> Having seen the change, I don't think I like `InfoContext`, sorry! How about just `Context`?
Sounds good to me. Will apply, thanks!
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73484/new/
https://reviews.llvm.org/D73484
    
    
More information about the llvm-commits
mailing list