[PATCH] D73484: [llvm-readobj] - Improve error message reported by DynRegionInfo.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 30 01:24:37 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with the suggested change.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:139
+  /// Error prefix. Used for error reporting to provide more information.
+  std::string InfoContext;
+  /// Region size name. Used for error reporting.
----------------
Having seen the change, I don't think I like `InfoContext`, sorry! How about just `Context`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73484/new/

https://reviews.llvm.org/D73484





More information about the llvm-commits mailing list