[PATCH] D73313: [Attributor] Use fine-grained liveness in all helpers

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5751
+      recordDependence(*FnLivenessAA, *QueryingAA,
+                       BlockLivenessOnly ? DepClass : DepClassTy::OPTIONAL);
+    return true;
----------------
sstefan1 wrote:
> Why not use just `DepClass`?
> 
> Also, IMO, `BlockLivenessOnly` isn't very useful name here. Not sure what would be the best name, though. Maybe `CheckFnLivenessOnly`
> Why not use just DepClass?

Good question. That might just work, I'll try it and adopt it silently if it does ;)

> Also, IMO, BlockLivenessOnly isn't very useful name here. Not sure what would be the best name, though. Maybe CheckFnLivenessOnly

I'm not proud of the name... Maybe `CheckBBLivenessOnly`? I fear `FnLiveness` is too "coarse".




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73313/new/

https://reviews.llvm.org/D73313