[PATCH] D73313: [Attributor] Use fine-grained liveness in all helpers
Stefan Stipanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 01:33:25 PST 2020
sstefan1 added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5751
+ recordDependence(*FnLivenessAA, *QueryingAA,
+ BlockLivenessOnly ? DepClass : DepClassTy::OPTIONAL);
+ return true;
----------------
Why not use just `DepClass`?
Also, IMO, `BlockLivenessOnly` isn't very useful name here. Not sure what would be the best name, though. Maybe `CheckFnLivenessOnly`
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:5787
- // We actually used liveness information so we have to record a dependence.
- recordDependence(*LivenessAA, AA, DepClassTy::OPTIONAL);
+ // If we haven't succeeded we query the specific livess info for the IRP.
+ const AAIsDead *IsDeadAA;
----------------
typo: liveness
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73313/new/
https://reviews.llvm.org/D73313
More information about the llvm-commits
mailing list