[PATCH] D73583: Handle non-absolute include dirs properly for both dwarf4 and dwarf5.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 29 11:40:25 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/DebugInfo/symbolize-paths.s:9
+# Absolute include-dirs should not have comp-dir prepended
+# CHECK: /absolute{{/|\\|\\\\}}1.cc:1:0
+# Relative include-dirs should have comp-dir prepended	
----------------
This should look like:

```
# Absolute include-dirs should not have comp-dir prepended
# CHECK: /absolute{{/|\\}}1.cc:1:0
# Relative include-dirs should have comp-dir prepended	
# CHECK: /comp_dir{{/|\\}}relative{{/|\\}}2.cc:2:1
```

> `  .file 2 "relative" "2.cc"`

The path components are concatenated by `\\` on Windows.

thakis has fixed the test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73583/new/

https://reviews.llvm.org/D73583





More information about the llvm-commits mailing list