[PATCH] D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect.

[Aart Bik via Phabricator via llvm-commits]

aartbik added inline comments.


================
Comment at: mlir/include/mlir/Dialect/VectorOps/VectorOps.td:953
+
+    If reducing rank ('n' > 'k'), result dimension sizes must be a product
+    of contiguous source dimension sizes.
----------------
we have a mixed bag of notation (variables with and without quotes) in our descriptions in this file and at some point we should unify this; in this case, I find n > k easier to read, and the n and k do no refer back to any parameters in real code anyway


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1616
+// sequence of the elements of 'b'. Returns false otherwise.
+static bool verifyShapeCastDims(ArrayRef<int64_t> a, ArrayRef<int64_t> b) {
+  unsigned rankA = a.size();
----------------
technically this is not a verify since it returns a bool, not a LogicalResult.
how about hasMatchingShapeCastDims or something like that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73635/new/

https://reviews.llvm.org/D73635