[PATCH] D73635: [mlir][VectorOps] Add ShapeCastOp to the vector ops dialect.

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1614
+
+// Returns true if each element of 'a' is equal to the product of a contiguous
+// sequence of the elements of 'b'. Returns false otherwise.
----------------
Use /// for top level comments


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1674
+  if (sourceVectorType && resultVectorType)
+    return verifyVectorShapeCast(op.getOperation(), sourceVectorType,
+                                 resultVectorType);
----------------
.getOperation isn't necessary.


================
Comment at: mlir/lib/Dialect/VectorOps/VectorOps.cpp:1690
+    if (failed(verifyVectorShapeCast(
+            op.getOperation(),
+            sourceTupleType.getType(i).cast<VectorType>(),
----------------
Same here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73635/new/

https://reviews.llvm.org/D73635