[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

LGTM, with the suggested doc changes.



================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:230
 
+  * Prints an address's dwarf discriminator when it is non-zero. Clang only
+    includes discriminators when compiling with -fdebug-info-for-profiling.
----------------
I might replace "dwarf" with "debug data" for more generality. I might also change the second sentence to be a little more general (the "only" feels like it could rot easily). How about "One way to produce discriminators is to compile with clang's -fdebug-info-for-profiling"?


================
Comment at: llvm/docs/CommandGuide/llvm-symbolizer.rst:252
+    $ llvm-symbolizer --output-style=GNU --obj=profiling.elf 0x401167 -p -i=0
+    main at /usr/local/google/home/saugustine/tmp/test.cpp:15 (discriminator 2)
+
----------------
Change this path to something more generic like /tmp/test.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318