[PATCH] D73318: Print discriminators when printing .debug_line in GNU style.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added a comment.

In D73318#1838181 <https://reviews.llvm.org/D73318#1838181>, @jhenderson wrote:

> Is there a particular reason to restrict this to GNU style? I think it's okay to expand on the LLVM style too, but might be worth getting more opinions on it.


LLVM output style already prints the column number (file:line:column), which tells you the same thing as the discriminator, but at a higher level that is more friendly for users. I'm open to adding it, but it seems a bit redundant.

Otherwise updated.

In D73318#1845267 <https://reviews.llvm.org/D73318#1845267>, @saugustine wrote:

> - Document how and when --output-style=GNU prints discriminators


I debated whether or not to add the -fdebug-info-for-profiling option to the top compile commands, but it seemed to distract from the main point. Let me know if this is acceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73318/new/

https://reviews.llvm.org/D73318