[PATCH] D73601: [X86] Fix isOffsetSuitableForCodeModel

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 28 23:37:55 PST 2020


MaskRay added a comment.

In D73601#1846047 <https://reviews.llvm.org/D73601#1846047>, @craig.topper wrote:

> Instead of a new parameter is it possible to work something into the AddressingMode struct so that it gets restored when we restore from a backup AM?
>
> Do you have a test case?


The bug was somewhat urgent and was breaking our release. @craig.topper So sorry, I went ahead and committed D73606 <https://reviews.llvm.org/D73606>.

I made more description there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73601/new/

https://reviews.llvm.org/D73601





More information about the llvm-commits mailing list