[PATCH] D73601: [X86] Fix isOffsetSuitableForCodeModel

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:1415
   // If there's no offset to fold, we don't need to do any work.
   if (Offset == 0)
     return false;
----------------
Without the test case, I can't be sure. But is the bug really just here where we don't check anything if the Offset is 0. But we still need to do the check if AM.Disp is already non-zero?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73601/new/

https://reviews.llvm.org/D73601