[PATCH] D73488: [mlir] add lowering from affine.min to std
Alex Zinenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jan 27 13:57:30 PST 2020
ftynse marked 2 inline comments as done.
ftynse added inline comments.
================
Comment at: mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp:274
+// Emit instructions that correspond to computing the minimum value amoung the
+// values of a (potentially) multi-output affine map applied to `operands`.
----------------
rriddle wrote:
> These should be ///
The rest of the file uses `//`, so I went for consistency here. We can batch-update.
================
Comment at: mlir/lib/Conversion/AffineToStandard/AffineToStandard.cpp:279
+ if (auto values =
+ expandAffineMap(builder, loc, map, llvm::to_vector<4>(operands)))
+ return buildMinMaxReductionSeq(loc, CmpIPredicate::slt, *values, builder);
----------------
rriddle wrote:
> Can we just change expandAffineMap to use ValueRange instead?
It affects more than just that function (I tried and stopped after third jump) so it's better of as a separate NFC change. WIll do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73488/new/
https://reviews.llvm.org/D73488
More information about the llvm-commits
mailing list