[PATCH] D73446: AMDGPU/GlobalISel: Legalize a16 images

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D73446#1842443 <https://reviews.llvm.org/D73446#1842443>, @arsenm wrote:

> In D73446#1842422 <https://reviews.llvm.org/D73446#1842422>, @nhaehnle wrote:
>
> > Why is this conceptually a legalization rather than part of the instruction selection?
>
>
> The register layout packing/unpacking code should be exposed to the legalizer and combines. Doing it later means it could possibly be in a waterfall loop, and won't benefit from the combines on the pack/unpack code.


More abstractly, selection should operate on the types expected for the final instruction. It's the legalizer's job to get registers that are the right type/size


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73446/new/

https://reviews.llvm.org/D73446