[PATCH] D73446: AMDGPU/GlobalISel: Legalize a16 images

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 27 09:33:00 PST 2020


arsenm added a comment.

In D73446#1842422 <https://reviews.llvm.org/D73446#1842422>, @nhaehnle wrote:

> Why is this conceptually a legalization rather than part of the instruction selection?


The register layout packing/unpacking code should be exposed to the legalizer and combines. Doing it later means it could possibly be in a waterfall loop, and won't benefit from the combines on the pack/unpack code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73446/new/

https://reviews.llvm.org/D73446





More information about the llvm-commits mailing list