[PATCH] D73427: [mlir] Refactor the implementation of Symbol use lists.

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 26 01:15:01 PST 2020


rriddle created this revision.
rriddle added a reviewer: mehdi_amini.
Herald added subscribers: llvm-commits, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, burmako, jpienaar.
Herald added a reviewer: nicolasvasilache.
Herald added a project: LLVM.

This revision refactors the implementation of the symbol use-list functionality to be a bit cleaner, as well as easier to reason about. Aside from code cleanup, this revision updates the user contract to never recurse into operations if they define a symbol table. The current functionality, which does recurse, makes it difficult to examine the uses held by a symbol table itself. Moving forward users may provide a specific region to examine for uses instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73427

Files:
  mlir/include/mlir/IR/SymbolTable.h
  mlir/lib/IR/SymbolTable.cpp
  mlir/test/lib/IR/TestSymbolUses.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73427.240421.patch
Type: text/x-patch
Size: 26894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200126/b728d871/attachment-0001.bin>


More information about the llvm-commits mailing list