[PATCH] D73301: [PatchableFunction] Allow empty entry MachineBasicBlock

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In D73301#1839163 <https://reviews.llvm.org/D73301#1839163>, @MaskRay wrote:

> @hans OK to cherry pick this commit? We would also need d232c215669cb57f5eb4ead40a4a336220dbc429 <https://reviews.llvm.org/rGd232c215669cb57f5eb4ead40a4a336220dbc429> ([AsmPrinter] Don't emit __patchable_function_entries entry if "patchable-function-entry"="0"; a GCC compatibility issue I did not notice when I implemented -fpatchable-function-entry=N,0).


Yes, go ahead.

> If users want to see a complete -fpatchable-function-entry=N,M, instead of just -fpatchable-function-entry=N,0 , in clang 10.0.0, we will need D73070 <https://reviews.llvm.org/D73070>, D73071 <https://reviews.llvm.org/D73071>, and D73072 <https://reviews.llvm.org/D73072> as well (N,M where M>0 is currently not used, though someone told me that Linux arch/arm64 may want to do that in the future. If that is the case, supporting a complete N,M, not just N,0 can simplify Linux kernel side configure test.)

I think you're the best judge of whether we should merge these. I'm okay either way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73301/new/

https://reviews.llvm.org/D73301