[llvm] 44b4967 - [AArch64][GlobalISel] Remove duplicate attribute lookup code that was supposed to be cached. NFC.

Amara Emerson via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 23 15:50:19 PST 2020


Author: Amara Emerson
Date: 2020-01-23T15:50:08-08:00
New Revision: 44b496758f177df2655b6adf88173e552aacec05

URL: https://github.com/llvm/llvm-project/commit/44b496758f177df2655b6adf88173e552aacec05
DIFF: https://github.com/llvm/llvm-project/commit/44b496758f177df2655b6adf88173e552aacec05.diff

LOG: [AArch64][GlobalISel] Remove duplicate attribute lookup code that was supposed to be cached. NFC.

When I cached this a long time ago it seems I forgot to remove the locally
declared variable of the same name in select(), so the caching wasn't having
any compile time benefit. Doh.

Added: 
    

Modified: 
    llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp b/llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
index 30fdd55e7473..a582df935dad 100644
--- a/llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
+++ b/llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp
@@ -1517,8 +1517,6 @@ bool AArch64InstructionSelector::select(MachineInstr &I) {
     // Speculation tracking/SLH assumes that optimized TB(N)Z/CB(N)Z
     // instructions will not be produced, as they are conditional branch
     // instructions that do not set flags.
-    bool ProduceNonFlagSettingCondBr =
-        !MF.getFunction().hasFnAttribute(Attribute::SpeculativeLoadHardening);
     if (ProduceNonFlagSettingCondBr && selectCompareBranch(I, MF, MRI))
       return true;
 


        


More information about the llvm-commits mailing list