[PATCH] D73027: [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses(PR42151).
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 22 08:31:47 PST 2020
jdoerfert added inline comments.
================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:1395
- (void)foundBlock; (void)GotWorklistLimit;
- assert((foundBlock || GotWorklistLimit) && "Current block not in cache?");
}
----------------
ebrevnov wrote:
> jdoerfert wrote:
> > Why is the `foundBlock` stuff gone?
> This is change was done in the previous version of the patch. The reason for that was invariant loads which are not expected to be found in the cache. Now this whole cycle is guarded with !isInvariantLoad and we can restore previous code.
Let's do that then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73027/new/
https://reviews.llvm.org/D73027
More information about the llvm-commits
mailing list