[PATCH] D73027: [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses(PR42151).

[Evgeniy via Phabricator via llvm-commits]

ebrevnov marked an inline comment as done.
ebrevnov added a comment.

In D73027#1832510 <https://reviews.llvm.org/D73027#1832510>, @jdoerfert wrote:

> Just to make sure, this contains a test for the regression that was reported and lead to the initial revert, correct?


Yes. It's @test4.



================
Comment at: llvm/lib/Analysis/MemoryDependenceAnalysis.cpp:1395
-    (void)foundBlock; (void)GotWorklistLimit;
-    assert((foundBlock || GotWorklistLimit) && "Current block not in cache?");
   }
----------------
jdoerfert wrote:
> Why is the `foundBlock` stuff gone?
This is change was done in the previous version of the patch. The reason for that was invariant loads which are not expected to be found in the cache. Now this whole cycle is guarded with !isInvariantLoad and we can restore previous code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73027/new/

https://reviews.llvm.org/D73027