[PATCH] D72192: AMDGPU/GlobalISel: Fix RegBankSelect for G_INSERT_VECTOR_ELT

Wed Jan 22 08:02:29 PST 2020

arsenm closed this revision.
arsenm marked 2 inline comments as done.
arsenm added a comment.

df8f381e4601ccb0a8250b7c24e27f00856c8ce4

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def:223
+  if (BankID == AMDGPU::VGPRRegBankID)
+    return &ValMappingsSGPR64OnlyVGPR32[4];
+
----------------
kerbowa wrote:
> As a general note it's not obvious what are the mappings for SGPROnly64BreakDown/ValMappingsSGPR64OnlyVGPR32.
I added some comments to try to fix this. This will need to be cleaned up somehow when this is autogenerated

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72192/new/

https://reviews.llvm.org/D72192