[PATCH] D72949: [NFC] small rename of private member in InlineCost.cpp

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1940
         onInitializeSROAArg(SROAArg);
+        EnabledSROAAllocas.insert(SROAArg);
       }
----------------
davidxl wrote:
> mtrofin wrote:
> > davidxl wrote:
> > > This is not NFC?
> > It's NFC because it was executed before in InlineCostCallAnalyzer::onInitializeSROAArg(), which is/was the only current scenario.
> it is not strictly NFC (in the future) because previously it was called in the overrider function  of the derived class, where it is moved to the common path. Is it intended?
Yes, it (that initialization) should have been in the base class in the first place. The removal from the set is also in the base class, which is correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72949/new/

https://reviews.llvm.org/D72949