[PATCH] D72949: [NFC] small rename of private member in InlineCost.cpp
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 19 22:25:35 PST 2020
davidxl added inline comments.
================
Comment at: llvm/lib/Analysis/InlineCost.cpp:1940
onInitializeSROAArg(SROAArg);
+ EnabledSROAAllocas.insert(SROAArg);
}
----------------
mtrofin wrote:
> davidxl wrote:
> > This is not NFC?
> It's NFC because it was executed before in InlineCostCallAnalyzer::onInitializeSROAArg(), which is/was the only current scenario.
it is not strictly NFC (in the future) because previously it was called in the overrider function of the derived class, where it is moved to the common path. Is it intended?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72949/new/
https://reviews.llvm.org/D72949
More information about the llvm-commits
mailing list