[PATCH] D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D72585#1828333 <https://reviews.llvm.org/D72585#1828333>, @mehdi_amini wrote:

> Also, how does this patch compare to D72554 <https://reviews.llvm.org/D72554> ?


D72554 <https://reviews.llvm.org/D72554> seems focused on a different approach to breaking the cyclic dependency problem, which does not modify the llvm cmake environment, but has the same end result (always building the libraries with cyclic dependencies as static libraries.)
Either way could work.  My way  (in D69440 <https://reviews.llvm.org/D69440>) is simpler, but we'll need an "add_mlir_library" cmake infrastructure anyway to get to having libMLIR.so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72585/new/

https://reviews.llvm.org/D72585