[PATCH] D72585: [MLIR] Fixes for BUILD_SHARED_LIBS=on
Stephen Neuendorffer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 19 01:11:53 PST 2020
stephenneuendorffer added a comment.
In D72585#1828331 <https://reviews.llvm.org/D72585#1828331>, @mehdi_amini wrote:
> The changes overall looks fine to me, but this patch does not seem enough to build with ENABLE_SHARED_LIB right? We still have a cyclic dependency to break first I believe.
This depends on https://reviews.llvm.org/D69440. I added that as a 'parent' commit, which appears to be how phabricator represents such things.
This combined with "STATIC" annotations is enough to get BUILD_SHARED_LIB to work.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72585/new/
https://reviews.llvm.org/D72585
More information about the llvm-commits
mailing list