[PATCH] D72812: [IR] Module's NamedMD table needn't be 'void *'

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 17:42:47 PST 2020


dblaikie added inline comments.


================
Comment at: llvm/lib/IR/Module.cpp:87
   NamedMDList.clear();
+  NamedMDSymTab.clear();
   delete ValSymTab;
----------------
mehdi_amini wrote:
> Nit: Is this clear useful/needed?
> 
> (I don't know about the other ones, but the previous code wasn't doing any explicit "clear()" of the map before deleting it).
Faoir point - did that & cleaned up a couple of other things in 46ed93315fceec4c8c3cd3defada501a55eb96e2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72812/new/

https://reviews.llvm.org/D72812





More information about the llvm-commits mailing list