[PATCH] D72812: [IR] Module's NamedMD table needn't be 'void *'

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 16:16:02 PST 2020


mehdi_amini added inline comments.


================
Comment at: llvm/lib/IR/Module.cpp:87
   NamedMDList.clear();
+  NamedMDSymTab.clear();
   delete ValSymTab;
----------------
Nit: Is this clear useful/needed?

(I don't know about the other ones, but the previous code wasn't doing any explicit "clear()" of the map before deleting it).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72812/new/

https://reviews.llvm.org/D72812





More information about the llvm-commits mailing list