[PATCH] D72961: In early-ifconversion check that the operands of a PHI share a common regclass with the destination regclass.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 15:30:29 PST 2020


efriedma added a comment.

What is the restriction on the register classes of PHI operands, if they don't have to have to be same register class as the result?  I don't see any relevant documentation, or checks in MachineVerifier::checkPHIOps().



================
Comment at: llvm/lib/CodeGen/EarlyIfConversion.cpp:522
+    // We need to make sure the register classes have a common subclass
+    // to avoid cross-class copies.
+    const TargetRegisterClass *DstRC =
----------------
Not sure why we want to avoid a cross-class copy here; won't we generate a cross-class copy anyway in PHIElimination?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72961/new/

https://reviews.llvm.org/D72961





More information about the llvm-commits mailing list