[PATCH] D72942: [mlir][Linalg] Extend linalg vectorization to MatmulOp

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp:192
 
-SmallVector<Value, 0>
-mlir::linalg::vectorizeGenericLinalgOp(PatternRewriter &rewriter,
-                                       Operation *op) {
+SmallVector<Value, 0> mlir::linalg::vectorizeLinalgOp(PatternRewriter &rewriter,
+                                                      Operation *op) {
----------------
ftynse wrote:
> Why SmallVector<Value, 0> ?  Maybe just use `std::vector` if you don't need stack elements.
This connects to RewriterGen.cpp in subtle ways and the only thing I have found to work with brace initializations and without changing RewriterGen too much is this.
Ther eis an internal bug I filed if you want to try and make the world a better place.
For me, I have shelved it for now :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72942/new/

https://reviews.llvm.org/D72942