[PATCH] D72942: [mlir][Linalg] Extend linalg vectorization to MatmulOp

[Alex Zinenko via Phabricator via llvm-commits]

ftynse added a comment.

The change is mostly renaming/clean-up. I only have minor comments, feel free to land after addressing.



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/LinalgTransforms.cpp:192
 
-SmallVector<Value, 0>
-mlir::linalg::vectorizeGenericLinalgOp(PatternRewriter &rewriter,
-                                       Operation *op) {
+SmallVector<Value, 0> mlir::linalg::vectorizeLinalgOp(PatternRewriter &rewriter,
+                                                      Operation *op) {
----------------
Why SmallVector<Value, 0> ?  Maybe just use `std::vector` if you don't need stack elements.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72942/new/

https://reviews.llvm.org/D72942