[PATCH] D72926: [mlir] Generator converting LLVM intrinsics defs to MLIR ODS

[Andy Davis via Phabricator via llvm-commits]

andydavis1 added a comment.

Looks great. Thanks Alex!



================
Comment at: mlir/test/mlir-tblgen/intrinsics.td:22
+
+// This checks that the ODS we produce can be consumed by MLIR tablegen. We only
+// make sure the entire process does not fail and produces some C++. The shape
----------------
Great to have this test. Thanks for adding...


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:80
+    auto results = record.getValueAsListOfDefs(fieldResults);
+    for (const llvm::Record *r : results) {
+      (void)r;
----------------
assert(llvm::all_of(record.getValueAsListOfDefs(fieldResults) ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72926/new/

https://reviews.llvm.org/D72926