[PATCH] D72926: [mlir] Generator converting LLVM intrinsics defs to MLIR ODS

[River Riddle via Phabricator via llvm-commits]

rriddle added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:19
+#include "llvm/Support/Signals.h"
+#include "llvm/TableGen/Error.h"
+#include "llvm/TableGen/Main.h"
----------------
Are all of these headers necessary?


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:127
+  os << "        module, llvm::Intrinsic::" << intr.getProperRecordName()
+     << ");\n";
+  os << "    auto operands = llvm::to_vector<8, Value *>(\n";
----------------
Note you are going to have to provide the expected types here if any of them are overloaded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72926/new/

https://reviews.llvm.org/D72926