[PATCH] D72900: [DebugInfo] Support 64-bit DWARF for .debug_names.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Some parts of this could be extracted into a separate NFC (or mostly NFC) patch:

- The `Dwarf.h` part
- In `DWARFAcceleratorTable.h`, merging the Header and HeaderPOD structs, and removing the Padding field.  (Adding the Format field would still be part of the functional patch.)
- In `DWARFAcceleratorTable.cpp`, eliminating the Padding field, and introducing CommonHeaderSize in `DWARFDebugNames::Header::extract()`

That would make the rest of the patch a little more focused.  (Which overall looks pretty reasonable, although I'd prefer to wait for the next round before approving.)



================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:380
+                                       uint64_t *Offset) {
+  static const unsigned CommonHeaderSize = 2 + // Version
+                                           2 + // Padding
----------------
Could this be `constexpr` ?


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp:631
+      CUsBase +
+      SectionOffsetSize * (Hdr.CompUnitCount + Hdr.LocalTypeUnitCount) + 8 * TU;
   return Section.AccelSection.getU64(&Offset);
----------------
Is this line too long?  (Did you run clang-format-diff?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72900/new/

https://reviews.llvm.org/D72900