[PATCH] D72902: [WebAssembly] Fix RegStackify and ExplicitLocals to handle multivalue

[Thomas Lively via Phabricator via llvm-commits]

tlively marked 2 inline comments as done.
tlively added a comment.

Just looking for high-level feedback right now, especially on the inclusion of the script and generated test cases. Now that multivalue is testable, I will go back and clean up the previous patches in this chain.



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:839
       while (!TreeWalker.done()) {
-        MachineOperand &Op = TreeWalker.pop();
+        MachineOperand &Use = TreeWalker.pop();
 
----------------
I am thinking of splitting the renaming and re-typing of these variables into a separate NFC patch. Thoughts?


================
Comment at: llvm/test/CodeGen/WebAssembly/multivalue-stackify.py:4
+
+
+MAX_OPS = 4
----------------
I will add a comment to this file explaining what it does and why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72902/new/

https://reviews.llvm.org/D72902