[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 03:02:13 PST 2020


SouraVX marked 2 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2830
+  } else {
+    Asm->EmitULEB128(M.getMacinfoType());
+    Asm->EmitULEB128(M.getLine());
----------------
Since my emitMacroFileImpl causes the comments to be emitted in asm for both macinfo and macro section which is good. But this is sort of incomplete, since we're not emitting comments for macinfo type.
I'm planning to do a small factor on macinfo part also. To emit macro form comments for DW_MACINFO_define and others. 
Making asm more readeable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828





More information about the llvm-commits mailing list