[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX marked 8 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2777
+    DEBUG_LINE_OFFSET = 2,
+    OPCODE_OPERANDS_TABLE = 3
+  };
----------------
probinson wrote:
> DWARF does not define symbols for the flag bits, but I'd still expect to see these in Dwarf.def where they could be shared with the dumper code.
> Also, OPCODE_OPERANDS_TABLE should be 4 not 3; these are masks, not bit numbers.
Thanks for sharing this, I've added forms in Dwarf.def and exapanded the enum here. 
Will try to reuse this in corresponding dumping part.


================
Comment at: llvm/test/DebugInfo/X86/stringpool.ll:43
+; DARWIN: .section __DWARF,__debug_str,regular,debug
+; DARWIN: .asciz "yyyy" ## string offset=[[YYYY:[0-9]+]]
 !6 = !{!0}
----------------
probinson wrote:
> This captures the string offset into YYYY, but never uses the captured value.  The old version of the test did verify the offset was used, presumably somewhere in the __debug_info section.  So, this change has lost coverage.
Thanks for pointing this out.
Added corresponding debug info variable. Now we have back reference to info section from str section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828