[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

[Andrzej Warzynski via Phabricator via llvm-commits]

andwar added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1853
+    function that can be used to vectorize calls to the scalar
+    function. The Attribute consists of a comma separated list of
+    mangled names. The syntax for the mangled names is as follows:
----------------
fpetrogalli wrote:
> andwar wrote:
> > `scalar function` -> `scalar function that would otherwise we invoked by the call instruction`? Maybe that's too verbose.
> Hum, I am not convinced by this change. What's behind your suggestion?
You refer to `the scalar function`, but no scalar function is introduced beforehand.  I know what scalar function you mean, but IMO it's not obvious from the context. But I'm a non-native speaker, so maybe just me :)


================
Comment at: llvm/docs/LangRef.rst:1888
+    
+    For all targets (x86, Arm and Internal LLVM), the remaining tokens
+    can have the following values:
----------------
`For all targets (x86, Arm and Internal LLVM)` - `x86, Arm, internal LLVM` are not `all targets`. Did you mean all targets for which this attribute is currently supported?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798