[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

Thu Jan 16 11:30:02 PST 2020

fpetrogalli added inline comments.

================
Comment at: llvm/docs/LangRef.rst:1844

+Instruction Attributes
+----------------------
----------------
jdoerfert wrote:
> My problem/confusion was with the term Instruction here. These are (only) Call Site Attributes, correct?
Yes, the attribute I am describing here is an attribute that can be attached to a CallInst. I didn't know how to title the section, I am happy to suggestions.

================
Comment at: llvm/docs/LangRef.rst:1853
+    function that can be used to vectorize calls to the scalar
+    function. The Attribute consists of a comma separated list of
+    mangled names. The syntax for the mangled names is as follows:
----------------
andwar wrote:
> `scalar function` -> `scalar function that would otherwise we invoked by the call instruction`? Maybe that's too verbose.
Hum, I am not convinced by this change. What's behind your suggestion?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798