[PATCH] D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: mlir/cmake/modules/CMakeLists.txt:28-29
+set(MLIR_CONFIG_CODE "
+# Compute the installation prefix from this LLVMConfig.cmake file location.
+get_filename_component(MLIR_INSTALL_PREFIX \"\${CMAKE_CURRENT_LIST_FILE}\" PATH)")
+# Construct the proper number of get_filename_component(... PATH)
----------------
schweitz wrote:
> jpienaar wrote:
> > Nit: could you indent these to show the nesting?
> Sure. :)
Actually, this looks like it is in column-0 because it is quoted.  I'm going to leave it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72418/new/

https://reviews.llvm.org/D72418