[PATCH] D72418: [Flang] add some cmake code to allow for out-of-tree building of MLIR and LLVM

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added a comment.
Herald added a reviewer: nicolasvasilache.

I think you may have forgotten to upload the changed diff :) In general I think this looks good, I'd like to remove the duplicate functions but beyond that this should be good.



================
Comment at: mlir/cmake/modules/CMakeLists.txt:43-46
+#configure_file(
+#  ${CMAKE_CURRENT_SOURCE_DIR}/MlirConfig.cmake.in
+#  ${CMAKE_CURRENT_BINARY_DIR}/CMakeFiles/MlirConfig.cmake
+#  @ONLY)
----------------
schweitz wrote:
> jpienaar wrote:
> > Leftover from testing?
> This was leftover from cobbling things together from other LLVM projects. Other projects seem to setup this XXXConfig.cmake file, but I found it wasn't needed here.
> 
> We can remove these commented out lines, if you prefer.  I left them with the chance someone who knew CMake better had good reasons to build out an MLIRConfig.cmake rule.
Lets remove them, instead thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72418/new/

https://reviews.llvm.org/D72418