[PATCH] D72686: [AsmParser] Make directives case insensitive.

[David Spickett via Phabricator via llvm-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:5324
+void AsmParser::addDirective(StringRef directive, DirectiveKind kind) {
+  DirectiveKindMap[directive.lower()] = kind;
+}
----------------
ostannard wrote:
> Why is this change needed, when all the strings are already lower-case?
An attempt to make it harder to put mixed case in, though you could just DirectiveKindMap[<bla>] directly anyway.

I'll leave initializeDirective as it is and just add a comment at the top of the function saying that they should be lower case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72686/new/

https://reviews.llvm.org/D72686