[PATCH] D72686: [AsmParser] Make directives case insensitive.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added a comment.

> "The names are case insensitive for most targets, and usually written in lower case."

This suggests that there are exceptions, do you which targets and directives don't follow this?



================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:5324
+void AsmParser::addDirective(StringRef directive, DirectiveKind kind) {
+  DirectiveKindMap[directive.lower()] = kind;
+}
----------------
Why is this change needed, when all the strings are already lower-case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72686/new/

https://reviews.llvm.org/D72686