[PATCH] D70837: [RISCV] Support ABI checking with per function target-features

[Kuan Hsu Chen (Zakk) via Phabricator via llvm-commits]

khchen marked an inline comment as done.
khchen added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:58
+                          "target-abi)\n";
+    ABI = Subtarget.is64Bit() ? RISCVABI::ABI_LP64 : RISCVABI::ABI_ILP32;
+  } else if ((ABI == RISCVABI::ABI_ILP32D || ABI == RISCVABI::ABI_LP64D) &&
----------------
lenary wrote:
> I don't think we should be changing the ABI here if the user already chose one explicitly.
I follow the same behavior to changing the ABI. please see https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.cpp#L59-L68. If we want to change the original behavior maybe it should be another patch? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70837/new/

https://reviews.llvm.org/D70837