[PATCH] D70837: [RISCV] Support ABI checking with per function target-features

[Alex Bradbury via Phabricator via llvm-commits]

asb added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:194
+        !getSTI().getFeatureBits()[RISCV::FeatureStdExtF]) {
+      errs() << "Hard-float 'f' ABI can't be used for a target that "
+                "doesn't support the F instruction set extension (ignoring "
----------------
lenary wrote:
> I'm not sure we should be using `errs()` here directly, should we perhaps be using `report_fatal_error` here?
I implemented the RISCVBaseInfo checking using report_fatal_error initially, but moved to complaining via `errs()` after feedback that this better matched what other backends do in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70837/new/

https://reviews.llvm.org/D70837