[PATCH] D72225: Align branches within 32-Byte boundary(Prefix padding)

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/MC/MCAssembler.cpp:616
+      for (uint64_t i = 0; i != FragmentSize; ++i)
+        OS << char(BF.getValue());
+    }
----------------
skan wrote:
> LuoYuanke wrote:
> > Why we declare Value as int64_t in MCAlignFragment? It seems only 1 byte is needed. Or we add assert(BF.getValueSize() == 1)?
> I didn't decalre `Value` as `int64_t`, I declared it as `Optional<uint8_t>`
You are right.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72225/new/

https://reviews.llvm.org/D72225