[PATCH] D72225: Align branches within 32-Byte boundary(Prefix padding)

[Kan Shengchen via Phabricator via llvm-commits]

skan marked 4 inline comments as done.
skan added inline comments.


================
Comment at: llvm/lib/MC/MCAssembler.cpp:616
+      for (uint64_t i = 0; i != FragmentSize; ++i)
+        OS << char(BF.getValue());
+    }
----------------
LuoYuanke wrote:
> Why we declare Value as int64_t in MCAlignFragment? It seems only 1 byte is needed. Or we add assert(BF.getValueSize() == 1)?
I didn't decalre `Value` as `int64_t`, I declared it as `Optional<uint8_t>`


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:532
+      PF->setAlignment(AlignBoundary);
+      PF->setEmitNops(true);
+      return;
----------------
LuoYuanke wrote:
> Just to confirm that there is no MCBoundaryAlignFragment between the 2 macro fusion instructions. Right?
Right, there is no. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72225/new/

https://reviews.llvm.org/D72225