[PATCH] D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:226
                                            Optional<Reloc::Model> RM) {
+  // AIX only supports PIC, RM option is ignored.
+  if (TT.isOSAIX())
----------------
I meant that the user-facing option processing code should generate an error message to prevent setting something other than PIC for AIX.

The code here should assert `!RM.hasValue() || *RM == Reloc::PIC_` for AIX.


================
Comment at: llvm/unittests/CodeGen/CMakeLists.txt:17
   AArch64SelectionDAGTest.cpp
+  AIXRelocModelTest.cpp
   DIEHashTest.cpp
----------------
Given the location of the code change, I think `unittests/Target/PowerPC` would be where the new test would go?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72479/new/

https://reviews.llvm.org/D72479