[PATCH] D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX

[Steven Wan via Phabricator via llvm-commits]

stevewan added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:234
+  // Big Endian PPC and AIX default to PIC.
+  if (TT.getArch() == Triple::ppc64 || TT.isOSAIX())
     return Reloc::PIC_;
----------------
hubert.reinterpretcast wrote:
> Would it make sense to disable setting anything other than PIC for AIX as part of this work?
True, AIX only supports PIC.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-pic-default.ll:1
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -mcpu=pwr4 -mtriple powerpc64-ibm-aix-xcoff < %s | FileCheck --check-prefix=CHECK64 %s
----------------
hubert.reinterpretcast wrote:
> I think using an API unit test instead of a LIT test would be more direct.
Sure, add it to "llvm/unittests/CodeGen/" I guess?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72479/new/

https://reviews.llvm.org/D72479