[PATCH] D71617: [WIP][NFC][Attributor] noalias attribute deduction fixme

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I found two minor problems that might solve the test issues we see.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2470
+            A.getAAFor<AAReachability>(*this, IRPosition::function(*ScopeFn),
+                                       /* TrackDependence */ false);
+
----------------
You need to track dependences here. just remove the parameter for now, e.g. `A.getAAFor<AAReachability>(*this, IRPosition::function(*ScopeFn))`


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2482
+
+            if (!NoCaptureAA.isAssumedNoCapture())
+              return true;
----------------
Remove the `!` here. A use is OK, thus we return `true` if it is assumed not captured.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71617/new/

https://reviews.llvm.org/D71617