[PATCH] D71617: [WIP][NFC][Attributor] noalias attribute deduction fixme

[pankaj gode via Phabricator via llvm-commits]

pgode updated this revision to Diff 237031.
pgode added a comment.

Updated patch which considers the review comments.

The pthreads.ll test still shows noalias for all 4 callsites. 
I think, as the Pred is executed recursively for individual use, so the reachability condition satisfies for the other 3 callsites as well.

Should we track the noalias for previous use as well ?  
For this we may have to add extra bool to the predicate for noalias tracking i.e.

  auto UsePred = [&](const Use &U, bool &Follow, bool &CurrUseNoalias) -> bool {

Then we also need to modify the checkForAllUses definition, to check this value.  Not sure we need such mechanism.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71617/new/

https://reviews.llvm.org/D71617

Files:
  llvm/lib/Transforms/IPO/Attributor.cpp
  llvm/test/Transforms/Attributor/IPConstantProp/pthreads.ll
  llvm/test/Transforms/Attributor/callbacks.ll
  llvm/test/Transforms/Attributor/noalias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71617.237031.patch
Type: text/x-patch
Size: 7424 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200109/4c9b7079/attachment.bin>