[PATCH] D72369: DWARFDebugLine.cpp: Format NULL as "(null)" to avoid UB

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

In D72369#1812230 <https://reviews.llvm.org/D72369#1812230>, @hubert.reinterpretcast wrote:

> In D72369#1812104 <https://reviews.llvm.org/D72369#1812104>, @jhenderson wrote:
>
> > I'd still really like to see a test that tests the other code path that tries to print DW_LNS_* (see the inline comment). The obvious thing to me to do would be to update the unit test "ParserPrintsStandardOpcodesWhenRequested", but it would require changes to the DwarfGenerator to create a custom prologue. If you don't want to do this, that's okay, as the code path is already untested.
>
>
> Yes, that is rather out-of-the-way for what this patch is doing. My understanding is that you would be okay with letting this patch land?


Just wanted to suggest the idea, but what you've done is good on its own, thanks. LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72369/new/

https://reviews.llvm.org/D72369